Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UIREQ-1134: Migrate from mod-circulation endpoint to mod-circulation-bff for form #1221

Merged
merged 6 commits into from
Nov 9, 2024
Merged

UIREQ-1134: Migrate from mod-circulation endpoint to mod-circulation-bff for form #1221

merged 6 commits into from
Nov 9, 2024

Conversation

artem-blazhko
Copy link
Contributor

Purpose

Migrate to new mod-circulation-bff endpoints.

Refs

UIREQ-1134

@artem-blazhko artem-blazhko changed the title UIREQ-1134: UIREQ-1134: Migrate from mod-circulation endpoint to mod-circulation-bff for form Nov 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024 •
edited
Loading

Jest Unit Test Statistics

    1 files  ±0    52 suites  ±0   1m 23s ⏱️ -5s
786 tests  - 2  786 ✔️  - 2  0 💤 ±0  0 ❌ ±0 
787 runs   - 2  787 ✔️  - 2  0 💤 ±0  0 ❌ ±0 

Results for commit 917f5f6. ± Comparison against base commit 26e2eca.

♻️ This comment has been updated with latest results.

@artem-blazhko artem-blazhko marked this pull request as ready for review November 6, 2024 11:16
@artem-blazhko artem-blazhko requested a review from a team November 6, 2024 14:07
Terala-Priyanka
Terala-Priyanka reviewed Nov 7, 2024
View reviewed changes
Copy link
Contributor

@Terala-Priyanka Terala-Priyanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think -

  1. it is much relevant to mark the current version in development against version in package.json and
  2. mark the new version as 11.0.0 in progress on changelog.md as well.

Rest LGTM

@Terala-Priyanka Terala-Priyanka requested a review from a team November 7, 2024 07:58
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@artem-blazhko artem-blazhko merged commit 90bdf08 into UXPROD-4559-ECS Nov 9, 2024
5 checks passed
@artem-blazhko artem-blazhko deleted the UIREQ-1134 branch November 9, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Terala-Priyanka Terala-Priyanka Terala-Priyanka approved these changes

@Dmitriy-Litvinenko Dmitriy-Litvinenko Dmitriy-Litvinenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artem-blazhko @Dmitriy-Litvinenko @Terala-Priyanka